Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14849] Fix file(DOWNLOAD) by providing a relative path #2880

Merged
merged 1 commit into from
Jul 26, 2022
Merged

[14849] Fix file(DOWNLOAD) by providing a relative path #2880

merged 1 commit into from
Jul 26, 2022

Conversation

MiguelBarro
Copy link
Contributor

Description

Quick hotfix for cmake versions under 3.17 (like focal and bionic provided ones).
file(DOWNLOAD is not able (on unix base platforms) to default to working dir if only a filename is provided.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Refs 14849. Fix file(DOWNLOAD) by providing a relative path
9049644 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro self-assigned this Jul 26, 2022
@JLBuenoLopez JLBuenoLopez added this to the v2.7.1 milestone Jul 26, 2022
@JLBuenoLopez
Copy link
Contributor

@mergify backport 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2022 •
edited by JLBuenoLopez
Loading

backport 2.6.x

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@JLBuenoLopez JLBuenoLopez added the no-test Skip CI tests if PR marked with this label label Jul 26, 2022
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test this

JLBuenoLopez
JLBuenoLopez approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I am not able to test this fix locally. Once it is merged I will check that the Linux installer generator has been fixed as expected.

@MiguelCompany MiguelCompany merged commit 72cfe15 into master Jul 26, 2022
@MiguelCompany MiguelCompany deleted the hotfix/workaround_cmake_download_error branch July 26, 2022 14:41
@JLBuenoLopez
Copy link
Contributor

@Mergifyio backport 2.6.x

@mergify mergify bot mentioned this pull request Jul 27, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2022

backport 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 27, 2022
@MiguelBarro @mergify
Fix file(DOWNLOAD) by providing a relative path (#2880)
5fd0c67 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 72cfe15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees

@MiguelBarro MiguelBarro

Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelBarro @JLBuenoLopez @MiguelCompany